Review Request 113346: Fix for BUG:317902 Issue a warning when transcoding is not possible
Jai Luthra
me at jailuthra.in
Fri Oct 18 23:37:07 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113346/
-----------------------------------------------------------
Review request for Amarok.
Bugs: 317902
https://bugs.kde.org/show_bug.cgi?id=317902
Repository: amarok
Description
-------
When ffmpeg is not available, the transcoding dialog will not be skipped; rather it will add a note for the user to install an encoder.
Diffs
-----
src/core-impl/collections/support/CollectionLocationDelegateImpl.h 9d90580
src/core-impl/collections/support/CollectionLocationDelegateImpl.cpp 14fd251
src/core/collections/CollectionLocation.cpp 2385570
src/core/collections/CollectionLocationDelegate.h 3c80d07
src/transcoding/TranscodingAssistantDialog.h 0acb701
src/transcoding/TranscodingAssistantDialog.cpp 17fc250
src/transcoding/TranscodingAssistantDialog.ui 0ad83b2
Diff: http://git.reviewboard.kde.org/r/113346/diff/
Testing
-------
* Compiles
* Works as expected
Thanks,
Jai Luthra
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20131018/1c8ba7ad/attachment.html>
More information about the Amarok-devel
mailing list