Review Request 113057: I am trying to kill Bug 322016 - Apply button is always enabled in Playlist Layout Editor dialog

[Ricardo Varas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113057/
-----------------------------------------------------------

Review request for Amarok.


Bugs: 322016
    https://bugs.kde.org/show_bug.cgi?id=322016


Repository: amarok


Description
-------

I am trying to kill Bug 322016 - Apply button is always enabled in Playlist Layout Editor dialog.
In multiple parts I call the enable property for the Apply button and enable/disable it according to specific actions. I tried to cover all possible actions from a user --of course it begins in the disabled status as requested and it's disabled after the user clicks it --.
One thing I am not happy about is the fact that when the Token (the option with the tool icon) is used to configure the playlist items such as album, album artist, etc. then the Apply button is always enabled and I believe under that case it should only become enabled if the Configuration for... dialog's OK button is clicked, and remain disabled after the Cancel button is clicked or the dialog is closed. I think LayoutEditDialog.cpp is called every time the token is chosen but right not I am unable to understand how they are connected LayoutEditDialog.cpp and PlaylistLayoutEditDialog.cpp.
I'd appreciate if someone can help me understand this one and put together a good patch for this bug.
Thanks.


Diffs
-----

  PlaylistLayoutEditDialog1.cpp 99aee2a 

Diff: http://git.reviewboard.kde.org/r/113057/diff/


Testing
-------


Thanks,

Ricardo Varas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20131002/0174a3a5/attachment.html>