Review Request 114142: GSoC 2013: AudioCD

[Tatjana Gornak]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114142/
-----------------------------------------------------------

Review request for Amarok.


Repository: amarok


Description
-------

Audio ?D collection refactoring.

P.S. If it is necessary I split this patch onto several pieces and submit them separately.


Diffs
-----

  cmake/modules/FindCDDB.cmake PRE-CREATION 
  cmake/modules/FindCdIO.cmake PRE-CREATION 
  cmake/modules/FindCdIOCDDA.cmake PRE-CREATION 
  cmake/modules/FindICU.cmake PRE-CREATION 
  cmake/modules/FindParanoia.cmake PRE-CREATION 
  src/CMakeLists.txt 70fb67b 
  src/MainWindow.h 6af9868 
  src/MainWindow.cpp c92c10b 
  src/core-impl/collections/audiocd/AudioCdCollection.h dc2cad7 
  src/core-impl/collections/audiocd/AudioCdCollection.cpp 3dfa7c3 
  src/core-impl/collections/audiocd/AudioCdCollectionFactory.h PRE-CREATION 
  src/core-impl/collections/audiocd/AudioCdCollectionFactory.cpp PRE-CREATION 
  src/core-impl/collections/audiocd/AudioCdCollectionLocation.h f6ca3b8 
  src/core-impl/collections/audiocd/AudioCdCollectionLocation.cpp 321f0cd 
  src/core-impl/collections/audiocd/AudioCdMeta.h af1f766 
  src/core-impl/collections/audiocd/AudioCdMeta.cpp 6007e87 
  src/core-impl/collections/audiocd/AudioCdPlaybackStarter.h PRE-CREATION 
  src/core-impl/collections/audiocd/AudioCdPlaybackStarter.cpp PRE-CREATION 
  src/core-impl/collections/audiocd/CMakeLists.txt a540bad 
  src/core-impl/collections/audiocd/EncodingSelectionDialog.h PRE-CREATION 
  src/core-impl/collections/audiocd/EncodingSelectionDialog.cpp PRE-CREATION 
  src/core-impl/collections/audiocd/FormatSelectionDialog.h 0d353ef 
  src/core-impl/collections/audiocd/FormatSelectionDialog.cpp 90cbb88 
  src/core-impl/collections/audiocd/FormatSelectionDialog.ui 9200301 
  src/core-impl/collections/audiocd/handler/AudioCdHandler.h f9e1d3c 
  src/core-impl/collections/audiocd/handler/AudioCdHandler.cpp 957167a 
  src/core-impl/collections/audiocd/helpers/CDDBHelper.h PRE-CREATION 
  src/core-impl/collections/audiocd/helpers/CDDBHelper.cpp PRE-CREATION 
  src/core-impl/collections/audiocd/helpers/CDTEXTHelper.h PRE-CREATION 
  src/core-impl/collections/audiocd/helpers/CDTEXTHelper.cpp PRE-CREATION 
  src/core-impl/collections/audiocd/helpers/ICUHelper.h PRE-CREATION 
  src/core-impl/collections/audiocd/helpers/ICUHelper.cpp PRE-CREATION 
  src/core-impl/collections/audiocd/helpers/MetaDataHelper.h PRE-CREATION 
  src/core-impl/collections/audiocd/helpers/MetaDataHelper.cpp PRE-CREATION 
  src/core-impl/collections/audiocd/helpers/ParanoiaHelper.h PRE-CREATION 
  src/core-impl/collections/audiocd/helpers/ParanoiaHelper.cpp PRE-CREATION 
  src/core-impl/collections/audiocd/helpers/WriteWavHelper.h PRE-CREATION 
  src/core-impl/collections/audiocd/helpers/WriteWavHelper.cpp PRE-CREATION 
  src/core-impl/collections/audiocd/meta/AudioCdAlbum.h PRE-CREATION 
  src/core-impl/collections/audiocd/meta/AudioCdAlbum.cpp PRE-CREATION 
  src/core-impl/collections/audiocd/meta/AudioCdMetaClass.h PRE-CREATION 
  src/core-impl/collections/audiocd/meta/AudioCdTrack.h PRE-CREATION 
  src/core-impl/collections/audiocd/meta/AudioCdTrack.cpp PRE-CREATION 
  src/core-impl/collections/audiocd/support/AudioCdConnectionAssistant.h 2c7c13b 
  src/core-impl/collections/audiocd/support/AudioCdConnectionAssistant.cpp 94ea959 
  src/core-impl/collections/audiocd/support/AudioCdDeviceInfo.h 499a391 
  src/core-impl/collections/audiocd/support/AudioCdDeviceInfo.cpp e971510 
  src/core-impl/collections/playdarcollection/PlaydarCollection.h 1a7ec89 
  src/core-impl/collections/playdarcollection/PlaydarCollection.cpp 5c2349d 
  src/core/collections/Collection.h 94d24d7 
  src/core/collections/Collection.cpp 01a2e8c 
  src/core/collections/CollectionLocation.cpp 209d6b4 

Diff: http://git.reviewboard.kde.org/r/114142/diff/


Testing
-------


Thanks,

Tatjana Gornak

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20131126/6348038d/attachment.html>