Review Request 113389: GSoC 2013 Revamping Scripting - Part 5/6 : Misc shared/

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113389/#review44045
-----------------------------------------------------------

Ship it!


This patch is good to go! (you may also commit it first separately from other work in your GSoC)

- Matěj Laitl


On Nov. 19, 2013, 7:27 p.m., Anmol Ahuja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113389/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2013, 7:27 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> Changes made to the tagging framework in shared/.
> 
> 
> Diffs
> -----
> 
>   shared/MetaValues.h 4b003ed 
>   shared/tag_helpers/APETagHelper.cpp ba39a10 
>   shared/tag_helpers/ASFTagHelper.cpp 3439845 
>   shared/tag_helpers/ID3v2TagHelper.cpp 03a3836 
>   shared/tag_helpers/MP4TagHelper.cpp 23d8879 
>   shared/tag_helpers/VorbisCommentTagHelper.cpp 8ff52c5 
> 
> Diff: http://git.reviewboard.kde.org/r/113389/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anmol Ahuja
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20131120/f37cd107/attachment.html>