Review Request 113389: GSoC 2013 Revamping Scripting - Part 5/6 : Misc shared/

[Anmol Ahuja]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113389/
-----------------------------------------------------------

(Updated Nov. 18, 2013, 7:20 p.m.)


Review request for Amarok.


Changes
-------

Create a new valMultiLyrics key instead of special handling. Should I get rid of multiple lyrics all together?


Repository: amarok


Description
-------

Changes made to the tagging framework in shared/.


Diffs (updated)
-----

  shared/MetaValues.h 4b003ed 
  shared/tag_helpers/APETagHelper.cpp ba39a10 
  shared/tag_helpers/ASFTagHelper.cpp 3439845 
  shared/tag_helpers/ID3v2TagHelper.h a9c9ab9 
  shared/tag_helpers/ID3v2TagHelper.cpp 03a3836 
  shared/tag_helpers/MP4TagHelper.cpp 23d8879 
  shared/tag_helpers/VorbisCommentTagHelper.cpp 8ff52c5 

Diff: http://git.reviewboard.kde.org/r/113389/diff/


Testing
-------


Thanks,

Anmol Ahuja

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20131118/a3a7f26e/attachment.html>