Review Request 113385: GSoC 2013 Revamping Scripting - Part 2/6 : Script Manager

Mark Kretschmann kretschmann at kde.org
Sat Nov 16 12:45:27 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113385/#review43809
-----------------------------------------------------------



src/ScriptManager.h
<http://git.reviewboard.kde.org/r/113385/#comment31450>

    Why are these functions commented out? Please remove completely if no longer used.


- Mark Kretschmann


On Oct. 22, 2013, 4:07 p.m., Anmol Ahuja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113385/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2013, 4:07 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> Changes made to the Script Manager.
> 
> 
> Diffs
> -----
> 
>   src/ScriptItem.h PRE-CREATION 
>   src/ScriptItem.cpp PRE-CREATION 
>   src/ScriptManager.h 1a252ca 
>   src/ScriptManager.cpp 7e4e891 
>   src/ScriptUpdater.h 0e9b37d 
>   src/ScriptUpdater.cpp f174248 
> 
> Diff: http://git.reviewboard.kde.org/r/113385/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anmol Ahuja
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20131116/b84361c1/attachment.html>


More information about the Amarok-devel mailing list