Review Request 113277: GSoC 2013 - Advanced Importers - 3/4: Tests for importers framework and concrete importers

Matěj Laitl matej at laitl.cz
Thu Nov 14 21:02:38 UTC 2013 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113277/#review43696
-----------------------------------------------------------

Ship it!


Tests are always welcome (thanks for them!), so this is obviously Ship it. However I suggest some shuffling around and adding 2 README files to ensure that some hypothetical $next_maintainer in the future can pick up our work easily.


Music
<http://git.reviewboard.kde.org/r/113277/#comment31400>

    I think this file belongs to tests/importers/. (perhaps tests/importers/files/ up to you)
    
    I also think it deserves Library.xml.README file that would very briefly explain raison d'être of the file and how to use it.



tests/importers/files/illFormedLibrary.xml
<http://git.reviewboard.kde.org/r/113277/#comment31401>

    I think the tests/importers/files/ directory deserves a README file with very brief description of the contents and what are they used for. Perhaps also with recipe how to (re)generate files in the testcollection directory.
    
    What is the size of the mysqle directory? (which I assume is an Amarok 2.x database (hint hint))


- Matěj Laitl


On Nov. 6, 2013, 8:24 p.m., Konrad Zemek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113277/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2013, 8:24 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> This review contains importers tests.
> 
> The tests/importers/TestImporterBase.cpp contains common tests for concrete
> importers. The tests load a prepared database and read it through the importer.
> It's therefore important that the prepared database contain certain data.
> The tests/importers/files/testCollection directory contains very small mp3
> files that are *not* used as a part of the tests, and instead are meant for
> creating the test database: one would just import these files into a media
> player, copy the media player's database and have it instantly ready for
> the common tests.
> 
> 
> Diffs
> -----
> 
>   Music PRE-CREATION 
>   tests/importers/CMakeLists.txt PRE-CREATION 
>   tests/importers/ImporterMocks.h PRE-CREATION 
>   tests/importers/ImporterMocks.cpp PRE-CREATION 
>   tests/importers/TestAmarokImporter.h PRE-CREATION 
>   tests/importers/TestAmarokImporter.cpp PRE-CREATION 
>   tests/importers/TestBansheeImporter.h PRE-CREATION 
>   tests/importers/TestBansheeImporter.cpp PRE-CREATION 
>   tests/importers/TestClementineImporter.h PRE-CREATION 
>   tests/importers/TestClementineImporter.cpp PRE-CREATION 
>   tests/importers/TestFastForwardImporter.h PRE-CREATION 
>   tests/importers/TestFastForwardImporter.cpp PRE-CREATION 
>   tests/importers/TestITunesImporter.h PRE-CREATION 
>   tests/importers/TestITunesImporter.cpp PRE-CREATION 
>   tests/importers/TestImporterBase.h PRE-CREATION 
>   tests/importers/TestImporterBase.cpp PRE-CREATION 
>   tests/importers/TestImporterManager.h PRE-CREATION 
>   tests/importers/TestImporterManager.cpp PRE-CREATION 
>   tests/importers/TestImporterProvider.h PRE-CREATION 
>   tests/importers/TestImporterProvider.cpp PRE-CREATION 
>   tests/importers/TestRhythmboxImporter.h PRE-CREATION 
>   tests/importers/TestRhythmboxImporter.cpp PRE-CREATION 
>   tests/importers/TestSimpleImporterConfigWidget.h PRE-CREATION 
>   tests/importers/TestSimpleImporterConfigWidget.cpp PRE-CREATION 
>   tests/importers/files/banshee.db PRE-CREATION 
>   tests/importers/files/clementine.db PRE-CREATION 
>   tests/importers/files/collection.db PRE-CREATION 
>   tests/importers/files/illFormedLibrary.xml PRE-CREATION 
>   tests/importers/files/mysqle/amarok/admin.MYD PRE-CREATION 
>   tests/importers/files/mysqle/amarok/admin.MYI PRE-CREATION 
>   tests/importers/files/mysqle/amarok/admin.frm PRE-CREATION 
>   tests/importers/files/mysqle/amarok/albums.MYD PRE-CREATION 
>   tests/importers/files/mysqle/amarok/albums.MYI PRE-CREATION 
>   tests/importers/files/mysqle/amarok/albums.frm PRE-CREATION 
>   tests/importers/files/mysqle/amarok/amazon.MYI PRE-CREATION 
>   tests/importers/files/mysqle/amarok/amazon.frm PRE-CREATION 
>   tests/importers/files/mysqle/amarok/artists.MYD PRE-CREATION 
>   tests/importers/files/mysqle/amarok/artists.MYI PRE-CREATION 
>   tests/importers/files/mysqle/amarok/artists.frm PRE-CREATION 
>   tests/importers/files/mysqle/amarok/bookmark_groups.MYI PRE-CREATION 
>   tests/importers/files/mysqle/amarok/bookmark_groups.frm PRE-CREATION 
>   tests/importers/files/mysqle/amarok/bookmarks.MYI PRE-CREATION 
>   tests/importers/files/mysqle/amarok/bookmarks.frm PRE-CREATION 
>   tests/importers/files/mysqle/amarok/composers.MYD PRE-CREATION 
>   tests/importers/files/mysqle/amarok/composers.MYI PRE-CREATION 
>   tests/importers/files/mysqle/amarok/composers.frm PRE-CREATION 
>   tests/importers/files/mysqle/amarok/db.opt PRE-CREATION 
>   tests/importers/files/mysqle/amarok/devices.MYD PRE-CREATION 
>   tests/importers/files/mysqle/amarok/devices.MYI PRE-CREATION 
>   tests/importers/files/mysqle/amarok/devices.frm PRE-CREATION 
>   tests/importers/files/mysqle/amarok/directories.MYD PRE-CREATION 
>   tests/importers/files/mysqle/amarok/directories.MYI PRE-CREATION 
>   tests/importers/files/mysqle/amarok/directories.frm PRE-CREATION 
>   tests/importers/files/mysqle/amarok/genres.MYD PRE-CREATION 
>   tests/importers/files/mysqle/amarok/genres.MYI PRE-CREATION 
>   tests/importers/files/mysqle/amarok/genres.frm PRE-CREATION 
>   tests/importers/files/mysqle/amarok/images.MYI PRE-CREATION 
>   tests/importers/files/mysqle/amarok/images.frm PRE-CREATION 
>   tests/importers/files/mysqle/amarok/labels.MYD PRE-CREATION 
>   tests/importers/files/mysqle/amarok/labels.MYI PRE-CREATION 
>   tests/importers/files/mysqle/amarok/labels.frm PRE-CREATION 
>   tests/importers/files/mysqle/amarok/lyrics.MYI PRE-CREATION 
>   tests/importers/files/mysqle/amarok/lyrics.frm PRE-CREATION 
>   tests/importers/files/mysqle/amarok/playlist_groups.MYI PRE-CREATION 
>   tests/importers/files/mysqle/amarok/playlist_groups.frm PRE-CREATION 
>   tests/importers/files/mysqle/amarok/playlist_tracks.MYI PRE-CREATION 
>   tests/importers/files/mysqle/amarok/playlist_tracks.frm PRE-CREATION 
>   tests/importers/files/mysqle/amarok/playlists.MYI PRE-CREATION 
>   tests/importers/files/mysqle/amarok/playlists.frm PRE-CREATION 
>   tests/importers/files/mysqle/amarok/podcastchannels.MYI PRE-CREATION 
>   tests/importers/files/mysqle/amarok/podcastchannels.frm PRE-CREATION 
>   tests/importers/files/mysqle/amarok/podcastepisodes.MYI PRE-CREATION 
>   tests/importers/files/mysqle/amarok/podcastepisodes.frm PRE-CREATION 
>   tests/importers/files/mysqle/amarok/statistics.MYD PRE-CREATION 
>   tests/importers/files/mysqle/amarok/statistics.MYI PRE-CREATION 
>   tests/importers/files/mysqle/amarok/statistics.frm PRE-CREATION 
>   tests/importers/files/mysqle/amarok/statistics_permanent.MYI PRE-CREATION 
>   tests/importers/files/mysqle/amarok/statistics_permanent.frm PRE-CREATION 
>   tests/importers/files/mysqle/amarok/statistics_tag.MYI PRE-CREATION 
>   tests/importers/files/mysqle/amarok/statistics_tag.frm PRE-CREATION 
>   tests/importers/files/mysqle/amarok/tracks.MYD PRE-CREATION 
>   tests/importers/files/mysqle/amarok/tracks.MYI PRE-CREATION 
>   tests/importers/files/mysqle/amarok/tracks.frm PRE-CREATION 
>   tests/importers/files/mysqle/amarok/urls.MYD PRE-CREATION 
>   tests/importers/files/mysqle/amarok/urls.MYI PRE-CREATION 
>   tests/importers/files/mysqle/amarok/urls.frm PRE-CREATION 
>   tests/importers/files/mysqle/amarok/urls_labels.MYD PRE-CREATION 
>   tests/importers/files/mysqle/amarok/urls_labels.MYI PRE-CREATION 
>   tests/importers/files/mysqle/amarok/urls_labels.frm PRE-CREATION 
>   tests/importers/files/mysqle/amarok/years.MYD PRE-CREATION 
>   tests/importers/files/mysqle/amarok/years.MYI PRE-CREATION 
>   tests/importers/files/mysqle/amarok/years.frm PRE-CREATION 
>   tests/importers/files/mysqle/aria_log.00000001 PRE-CREATION 
>   tests/importers/files/mysqle/aria_log_control PRE-CREATION 
>   tests/importers/files/rhythmdb.xml PRE-CREATION 
>   tests/importers/files/testcollection/albumUnset.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/caseSensitiveAlbum1.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/caseSensitiveAlbum2.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/caseSensitiveAlbum3.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/caseSensitiveArtist1.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/caseSensitiveArtist2.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/caseSensitiveArtist3.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/caseSensitiveComposer1.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/caseSensitiveComposer2.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/caseSensitiveComposer3.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/caseSensitiveTitle1.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/caseSensitiveTitle2.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/caseSensitiveTitle3.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/composerUnset.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/discUnset.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/multiWordAlbum.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/multiWordArtist.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/multiWordComposer.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/multiWordTitle.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/testStatistics0.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/testStatistics1.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/testStatistics2.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/testStatistics3.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/testStatistics4.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/testStatistics5.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/testStatistics6.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/testStatistics7.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/testStatistics8.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/testStatistics9.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/testStatisticsNotSet0.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/testStatisticsNotSet1.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/testStatisticsNotSet2.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/testStatisticsNotSet3.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/testStatisticsNotSet4.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/testStatisticsNotSet5.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/testStatisticsNotSet6.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/testStatisticsNotSet7.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/testStatisticsNotSet8.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/testStatisticsNotSet9.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/trackUnset.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/trimAlbum1.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/trimAlbum2.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/trimAlbum3.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/trimArtist1.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/trimArtist2.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/trimArtist3.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/trimComposer1.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/trimComposer2.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/trimComposer3.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/trimTitle1.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/trimTitle2.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/trimTitle3.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/utfAlbum.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/utfArtist.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/utfComposer.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/utfTitle.mp3 PRE-CREATION 
>   tests/importers/files/testcollection/yearUnset.mp3 PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113277/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Konrad Zemek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20131114/1ac8d8f0/attachment-0001.html>

More information about the Amarok-devel mailing list