Review Request 113777: Lazy load scriptable service tracks

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113777/#review43325
-----------------------------------------------------------


Looks good to me, but please test that scriptable service tracks that are (remote) playlists do play right away when you double-click on them. (with play on double-click enabled)


src/services/scriptable/ScriptableServiceMeta.h
<http://git.reviewboard.kde.org/r/113777/#comment31198>

    Please initialize (to false, probably) this basic type in constructor as it is random otherwise.


- Matěj Laitl


On Nov. 9, 2013, 10:21 p.m., Anmol Ahuja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113777/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2013, 10:21 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> Prevent all the scriptable services from loading playlists at Amarok launch.
> 
> 
> Diffs
> -----
> 
>   src/services/scriptable/ScriptableServiceMeta.h 2db3951 
>   src/services/scriptable/ScriptableServiceMeta.cpp 8e96785 
> 
> Diff: http://git.reviewboard.kde.org/r/113777/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anmol Ahuja
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20131110/1ecc08e9/attachment.html>