Review Request 108717: nepomuk: implement custom QueryMaker

[Edward Hades Toroshchin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108717/
-----------------------------------------------------------

(Updated May 30, 2013, 7:12 p.m.)


Review request for Amarok and Vishesh Handa.


Changes
-------

style++


Description
-------

nepomuk: implement custom QueryMaker


Diffs (updated)
-----

  src/core-impl/collections/nepomukcollection/CMakeLists.txt 642919bd7b2188c6055308eabc07319ae48e14be 
  src/core-impl/collections/nepomukcollection/NepomukCache.h PRE-CREATION 
  src/core-impl/collections/nepomukcollection/NepomukCache.cpp PRE-CREATION 
  src/core-impl/collections/nepomukcollection/NepomukCollection.h 5737cb5861563a8f190a29badc15d9e3ef82faf1 
  src/core-impl/collections/nepomukcollection/NepomukCollection.cpp 8c35e3dda0e3dc9a23affe1d18cc69de4d24d58c 
  src/core-impl/collections/nepomukcollection/NepomukConstructMetaJob.h 66e2473f16227f462c5a3838c71f311b6594333a 
  src/core-impl/collections/nepomukcollection/NepomukConstructMetaJob.cpp 19743fe02b1d0c9dd4785d01909a4231b3a69e90 
  src/core-impl/collections/nepomukcollection/NepomukInquirer.cpp PRE-CREATION 
  src/core-impl/collections/nepomukcollection/NepomukParser.h PRE-CREATION 
  src/core-impl/collections/nepomukcollection/NepomukParser.cpp PRE-CREATION 
  src/core-impl/collections/nepomukcollection/NepomukQueryMaker.h PRE-CREATION 
  src/core-impl/collections/nepomukcollection/NepomukQueryMaker.cpp PRE-CREATION 
  src/core-impl/collections/nepomukcollection/NepomukSelectors.h PRE-CREATION 
  src/core-impl/collections/nepomukcollection/meta/NepomukAlbum.h 8456ddb8d952e130816d01fc312c8df3146e83d1 
  src/core-impl/collections/nepomukcollection/meta/NepomukAlbum.cpp 76c9136f9d4f5ba77cac49b242b3aa3b2d844c0c 
  src/core-impl/collections/nepomukcollection/meta/NepomukArtist.h 7cf533e760b0a06e5a2316693e13f6aea0ac3dcd 
  src/core-impl/collections/nepomukcollection/meta/NepomukArtist.cpp 34d7c8f9c32f96be0ef5f81de9d58bfedb510c2d 
  src/core-impl/collections/nepomukcollection/meta/NepomukComposer.h 837c37fa5dce5c3c10e6840f618cf72430b51b3d 
  src/core-impl/collections/nepomukcollection/meta/NepomukComposer.cpp 33ba85ae11100e8ccbb5cc94a2d7d0e2007fdbd1 
  src/core-impl/collections/nepomukcollection/meta/NepomukGenre.cpp c34831ab4812f0241c0000eef844c2ea2397ae97 
  src/core-impl/collections/nepomukcollection/meta/NepomukLabel.h 6f2e54c3c6a0d350615cea0e335ed9f5c5a0eedf 
  src/core-impl/collections/nepomukcollection/meta/NepomukLabel.cpp 7e2a313e5eac91128d0ce211c6575ac3d8d2b1ab 
  src/core-impl/collections/nepomukcollection/meta/NepomukTrack.h 9a534dddac51fc39f9d3705f95b194f9669416ab 
  src/core-impl/collections/nepomukcollection/meta/NepomukTrack.cpp b9beca872cd7c7edc3e6b15662d0a49f42213c6d 
  src/core-impl/collections/nepomukcollection/meta/NepomukYear.h 9eca44fbcd3aab77149d864cb6d3e5d266cc8461 
  src/core-impl/collections/nepomukcollection/meta/NepomukYear.cpp 1d6e3b1066e13fd6adba15ae6b1d81f8ca28a5d9 
  src/statsyncing/collection/CollectionProvider.cpp 7e3bdd83214796fc37e0aef41225baedabe3fbda 

Diff: http://git.reviewboard.kde.org/r/108717/diff/


Testing
-------

Playing tracks from Nepomuk collection, browsing, filtering, adding/removing labels, statistics sync.


File Attachments
----------------


  http://git.reviewboard.kde.org/media/uploaded/files/2013/02/03/nepomuk-counting-querymaker.png

  http://git.reviewboard.kde.org/media/uploaded/files/2013/02/03/nepomuk-queries.png

  http://git.reviewboard.kde.org/media/uploaded/files/2013/02/03/nepomuk-sync.png


Thanks,

Edward Hades Toroshchin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130530/12f73cd9/attachment-0001.html>