Review Request 110498: Add refresh button to FileBrowser

Matěj Laitl matej at laitl.cz
Sat May 18 15:17:11 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110498/#review32743
-----------------------------------------------------------


This looks fine, although I suppose that pressing F5 (common shortcut for refresh) when the File View is focused has no effect? If not, please implement it and update this patch, it may be needed to override keyPressEvent() of the view.

- Matěj Laitl


On May 18, 2013, 1:23 p.m., Abhinandan Ramaprasath wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110498/
> -----------------------------------------------------------
> 
> (Updated May 18, 2013, 1:23 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> A tiny patch that adds a refresh button to the file browser.
> 
> 
> This addresses bug 213666.
>     https://bugs.kde.org/show_bug.cgi?id=213666
> 
> 
> Diffs
> -----
> 
>   src/browsers/filebrowser/FileBrowser.h 99b22c7 
>   src/browsers/filebrowser/FileBrowser.cpp 4b80774 
>   src/browsers/filebrowser/FileBrowser_p.h 39fa86d 
> 
> Diff: http://git.reviewboard.kde.org/r/110498/diff/
> 
> 
> Testing
> -------
> 
> yes, works.
> 
> 
> Thanks,
> 
> Abhinandan Ramaprasath
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130518/b672502e/attachment-0001.html>


More information about the Amarok-devel mailing list