Review Request 110498: Add refresh button to FileBrowser

Mark Kretschmann kretschmann at kde.org
Sat May 18 11:52:37 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110498/#review32730
-----------------------------------------------------------

Ship it!


Nevermind, I've now read the comments on this bug report:

https://bugs.kde.org/show_bug.cgi?id=213666

The arguments are valid. Directory watching does not work with some filesystems like NFS and CIFS. So I agree that this patch is useful.

- Mark Kretschmann


On May 18, 2013, 11:25 a.m., Abhinandan Ramaprasath wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110498/
> -----------------------------------------------------------
> 
> (Updated May 18, 2013, 11:25 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> A tiny patch that adds a refresh button to the file browser.
> 
> 
> This addresses bug 213666.
>     https://bugs.kde.org/show_bug.cgi?id=213666
> 
> 
> Diffs
> -----
> 
>   src/browsers/filebrowser/FileBrowser.h 99b22c7 
>   src/browsers/filebrowser/FileBrowser.cpp 4b80774 
>   src/browsers/filebrowser/FileBrowser_p.h 39fa86d 
> 
> Diff: http://git.reviewboard.kde.org/r/110498/diff/
> 
> 
> Testing
> -------
> 
> yes, works.
> 
> 
> Thanks,
> 
> Abhinandan Ramaprasath
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130518/dd4ded7a/attachment.html>


More information about the Amarok-devel mailing list