Review Request 109695: JJ#241066: Added a prepareToQuit() signal to amarokWindowScript

[Anmol Ahuja]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109695/
-----------------------------------------------------------

(Updated March 27, 2013, 11:51 p.m.)


Review request for Amarok.


Changes
-------

Removed the unnecessary running-script check and 1-second delay


Description (updated)
-------

Bug 241066 - JJ: Add Signals trackStop and amarokShutdown to Amarok scripting interface

Changes:
1. Added a prepareToQuit() signal to amarokWindowScript
2. Replaced kapp macro calls with App::instance() because quit() is not virtual

Note:
Signal trackFinished()[trackStop] already exists, so only added prepareToQuit()[amarokShutdown]


Diffs (updated)
-----

  src/scriptengine/AmarokScript.cpp 922e71d 
  src/dbus/mpris2/MediaPlayer2.cpp f86ccb3 
  src/scriptengine/AmarokWindowScript.h 5407579 
  src/dbus/mpris1/RootHandler.cpp e60eb1b 
  src/MainWindow.cpp 66f4f76 
  ChangeLog 284f188 
  src/App.cpp fdb4255 
  src/scriptengine/AmarokWindowScript.cpp 897e2da 

Diff: http://git.reviewboard.kde.org/r/109695/diff/


Testing
-------

Tested the new signal in a script


Thanks,

Anmol Ahuja

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130327/9b8335d4/attachment-0001.html>