Review Request 109470: A patch which allows us to distinguish between cached lyrics and lyrics newly downloaded from the internet.

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109470/#review29952
-----------------------------------------------------------


Review Board says you've uploaded a malformed patch, please fix it.


src/context/engines/lyrics/LyricsEngine.h
<http://git.reviewboard.kde.org/r/109470/#comment22321>

    The method name is badly choosen and it lacks documentation.


- Matěj Laitl


On March 23, 2013, 5:33 p.m., mayank jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109470/
> -----------------------------------------------------------
> 
> (Updated March 23, 2013, 5:33 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> It required modifications, when there is no change in the lyrics downloaded and lyrics retrieved from cache the title display of the lyrics browser changes to "Cached Lyrics" from "Lyrics" so we can tell the difference between old and new. 
> 
> 
> Diffs
> -----
> 
>   src/context/applets/lyrics/LyricsApplet.cpp 2394964 
>   src/context/engines/lyrics/LyricsEngine.h b187b73 
>   src/context/engines/lyrics/LyricsEngine.cpp 2befa91 
> 
> Diff: http://git.reviewboard.kde.org/r/109470/diff/
> 
> 
> Testing
> -------
> 
> Its working fine!
> 
> 
> Thanks,
> 
> mayank jha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130327/5dfe2de3/attachment.html>