Review Request 109470: A patch which allows us to distinguish between cached lyrics and lyrics newly downloaded from the internet.

mayank jha mjnovice at gmail.com
Tue Mar 19 10:43:15 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109470/
-----------------------------------------------------------

(Updated March 19, 2013, 10:43 a.m.)


Review request for Amarok, Samikshan Bairagya, Jasneet Bhatti, Bartosz Brachaczek, Tirtha Chatterjee, and Matěj Laitl.


Description
-------

It required modifications, when there is no change in the lyrics downloaded and lyrics retrieved from cache the title display of the lyrics browser changes to "Cached Lyrics" from "Lyrics" so we can tell the difference between old and new. 


Diffs (updated)
-----

  src/context/applets/lyrics/LyricsApplet.cpp 2394964 
  src/context/engines/lyrics/LyricsEngine.h b187b73 
  src/context/engines/lyrics/LyricsEngine.cpp 2befa91 

Diff: http://git.reviewboard.kde.org/r/109470/diff/


Testing
-------

Its working fine!


Thanks,

mayank jha

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130319/c812b282/attachment.html>


More information about the Amarok-devel mailing list