Review Request 109283: Bug 140198 - JJ: feature request: option to selectively disable submitting certain tracks/albums from collection to last.fm

[Vedant Agarwala]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109283/
-----------------------------------------------------------

(Updated March 7, 2013, 5:55 p.m.)


Review request for Amarok.


Changes
-------

This one shows the newly added (and changed tooltip)


Description
-------

Added a check-box to disable scobbling for tracks with a particular label. The label can be selected from a drop-down list or entered manually. Any track that contains this label is skipped from being submitted to last.fm for being scrobbled.


Diffs
-----

  src/services/lastfm/LastFmConfigWidget.ui 5c5e51b 
  src/services/lastfm/LastFmServiceConfig.h 3f33b72 
  src/services/lastfm/LastFmServiceSettings.h 41b2ead 
  src/services/lastfm/LastFmServiceSettings.cpp f6e1564 
  src/services/lastfm/ScrobblerAdapter.h ea74196 
  src/services/lastfm/ScrobblerAdapter.cpp b1a09f8 
  src/statsyncing/Process.cpp c42fdc4 
  src/statsyncing/ScrobblingService.h 971edd7 

Diff: http://git.reviewboard.kde.org/r/109283/diff/


Testing
-------

Builds and runs successfully.


File Attachments (updated)
----------------

screen shot of the last fm service settings
  http://git.reviewboard.kde.org/media/uploaded/files/2013/03/06/modifiedLastFm.png
updated settings widget
  http://git.reviewboard.kde.org/media/uploaded/files/2013/03/06/modifiedLastFm1.png
updated settings dialog ( with the tooltip )
  http://git.reviewboard.kde.org/media/uploaded/files/2013/03/07/modifiedLastFm4.png
with the correct tooltip :)
  http://git.reviewboard.kde.org/media/uploaded/files/2013/03/07/modifiedLastFm5.png


Thanks,

Vedant Agarwala

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130307/29d52296/attachment.html>