Review Request 108413: FindMySQLAmarok.cmake: use PATH_SUFFIXES

Commit Hook null at kde.org
Wed Mar 6 15:38:07 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108413/#review28692
-----------------------------------------------------------


This review has been submitted with commit 79adb8aba931c57059701867a77ea98ffdd2f670 by Matěj Laitl on behalf of Yury Georgievich Kudryashov to branch master.

- Commit Hook


On Jan. 15, 2013, 4:26 a.m., Yury Georgievich Kudryashov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108413/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2013, 4:26 a.m.)
> 
> 
> Review request for Amarok and Build System.
> 
> 
> Description
> -------
> 
> FindMySQLAmarok.cmake: use PATH_SUFFIXES
> 
> Drop ~/usr and /opt from find_path(). Use CMAKE_PREFIX_PATH.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindMySQLAmarok.cmake 910b434bda138117a4a2598bd7f5aa5f3d58ee10 
> 
> Diff: http://git.reviewboard.kde.org/r/108413/diff/
> 
> 
> Testing
> -------
> 
> - install mysql into a non-standard path
> - try to build amarok
> 
> 
> Thanks,
> 
> Yury Georgievich Kudryashov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130306/ebbe3a3f/attachment.html>


More information about the Amarok-devel mailing list