Review Request 109224: Patch for bug 315932 in Amarok. Resolving the window not coming up on launching the second time in Amarok.

[Mark Kretschmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109224/#review28647
-----------------------------------------------------------


Please don't apply this patch. Here's why:

Amarok is really not supposed to be running more than one instance at the same time (it's a "KUniqueApplication"). If you try to start another instance, you should be getting this message:

mark at serenity:~$ amarok
Amarok is already running!

Any command line flags will be processed by the already running instance. This is how the "%U" works.


Exception: If you run Amarok with the -m or --multipleinstances flag, it will happily start another instance.

 

- Mark Kretschmann


On March 5, 2013, 5:02 p.m., Harikrishnan S. wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109224/
> -----------------------------------------------------------
> 
> (Updated March 5, 2013, 5:02 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Resolved 315932, removed %U from amarok.desktop
> 
> 
> Diffs
> -----
> 
>   src/amarok.desktop 4fe72c0d96111f2bd8bdea3e12622e09320ad31c 
> 
> Diff: http://git.reviewboard.kde.org/r/109224/diff/
> 
> 
> Testing
> -------
> 
> Seems to be working. On launching the second time, the window does come up now. Also build perfectly.
> 
> 
> Thanks,
> 
> Harikrishnan S.
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130306/05b31540/attachment.html>