Review Request 109162: Fix: double click item to add to playlist in double click mode

Commit Hook null at kde.org
Tue Mar 5 16:41:53 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109162/#review28593
-----------------------------------------------------------


This review has been submitted with commit 40b1e87cad749a806098d5668fc5f5bc59ee6c7d by Matěj Laitl to branch master.

- Commit Hook


On Feb. 26, 2013, 12:16 a.m., Yichao Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109162/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2013, 12:16 a.m.)
> 
> 
> Review request for Amarok, Matěj Laitl and Ralf Engels.
> 
> 
> Description
> -------
> 
> Commit 2310a19341e583fcba8440ffec15b5fb58b3e2a6 make it impossible to add an item to playlist by double click in double click mode. This patch add it back.
> 
> P.S. inspired by that commit message, is it a good idea to add a list to the playlist by double click on the expander for double click mode? This won't collide with normal expand click and make it a lot easier to add a list to playlist in double click mode.
> 
> 
> Diffs
> -----
> 
>   src/browsers/CollectionTreeView.cpp 429158e 
> 
> Diff: http://git.reviewboard.kde.org/r/109162/diff/
> 
> 
> Testing
> -------
> 
> Compiled and run. Being able to add an item by double click again.
> 
> 
> Thanks,
> 
> Yichao Yu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130305/8cc8b101/attachment.html>


More information about the Amarok-devel mailing list