Review Request 109224: Patch for bug 315932 in Amarok. Resolving the window not coming up on launching the second time in Amarok.
Fabian Kosmale
0inkane at googlemail.com
Sat Mar 2 15:04:34 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109224/#review28384
-----------------------------------------------------------
I've tested the change and everything that worked before seems to still work. As I'm not an Amarok developer, I can't/don't want to give you a Ship It.
src/amarok.desktop
<http://git.reviewboard.kde.org/r/109224/#comment21201>
Minor nitpick: You have left trailing whitespace.
- Fabian Kosmale
On March 1, 2013, 1:14 p.m., Harikrishnan S. wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109224/
> -----------------------------------------------------------
>
> (Updated March 1, 2013, 1:14 p.m.)
>
>
> Review request for Amarok.
>
>
> Description
> -------
>
> Resolved bug:315932 found at https://bugs.kde.org/show_bug.cgi?id=315932
> Removed %U from amarok.desktop found at /src/amarok/src
>
>
> Diffs
> -----
>
> src/amarok.desktop 4fe72c0d96111f2bd8bdea3e12622e09320ad31c
>
> Diff: http://git.reviewboard.kde.org/r/109224/diff/
>
>
> Testing
> -------
>
> Seems to be working. On launching the second time, the window does come up now. Also build perfectly.
>
>
> Thanks,
>
> Harikrishnan S.
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130302/dbd0e3b3/attachment.html>
More information about the Amarok-devel
mailing list