Review Request 111275: putting Artist - Title of the current track to the clipboard using a shortcut

[fleissig fleissig]

> On June 28, 2013, 7:39 p.m., Matěj Laitl wrote:
> > src/MainWindow.cpp, lines 725-738
> > <http://git.reviewboard.kde.org/r/111275/diff/3/?file=166669#file166669line725>
> >
> >     Oh this is convoluted. What about
> >     
> >     QString text;
> >     Meta::ArtistPtr artist = currentTrack->artist();
> >     if( artist )
> >         text = artist->prettyName() + " - ";
> >     text += currentTrack->prettyName()
> >     
> >     clipboard->setText( text );

ok


- fleissig


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111275/#review35253
-----------------------------------------------------------


On June 28, 2013, 8:57 p.m., fleissig fleissig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111275/
> -----------------------------------------------------------
> 
> (Updated June 28, 2013, 8:57 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> putting Artist - Title of the current track to the clipboard using a shortcut
> 
> 
> This addresses bug 228872.
>     https://bugs.kde.org/show_bug.cgi?id=228872
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.h b2ee08014c110d1979176fe9d4abfad5076c1179 
>   src/MainWindow.cpp af47db7226244cc81f1a4f50000d3c980d758b93 
> 
> Diff: http://git.reviewboard.kde.org/r/111275/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> fleissig fleissig
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130628/1a56181a/attachment.html>