[amarok] /: Make playlist-related actions consistent throughout Amarok code (behaviour change)

[Matěj Laitl]

On 16. 6. 2013 Myriam Schweingruber wrote:
> > Options for the "activate" (double or single click, per configuration, if
> > we so choose) action; feel free to suggest more:
> > 
> > a) append track to playlist and start playing perhaps a different (depends
> > on other factors) track in the playlist, if not already playing. The old
> > behaviour.
> > 
> > b) just append to playlist.
> > 
> > c) insert after currently playing, play the track(s) immediately. The new
> > and controversial behaviour.
> > 
> > 
> > My personal preference:
> > +1 for c). rationale: double-click then behaves the same in playlist and
> > in
> > collection, some may fine it more consistent with other KDE apps like
> > Dolphin. At the same time I ack this may be too disruptive change and the
> > queue usage is weird.
> > 
> > +0,75 for b).
> > 
> > -1 for a). Rationale: the "start playing something arbitrary when not
> > already playing" aspect is something that really bugs me. We've had at
> > least 3 bug reports (mentioned in commit above) thinking this was a bug,
> > not something intentional, which means I'm not alone. I think that an
> > action shouldn't depend on current state (whether playing, queue state,
> > playback mode) that much.
> > 
> > 
> > Perhaps we could ditch all the special double-click handling (i.e. revert
> > to "activate" in Qt's sense, which is single or double click depending on
> > user configuration), ditch all the special "click even on text, not just
> > arrow, also expands" handling and go for b) then? If we agree on this,
> > I'm volunteering to implement this (requires more than just changes to
> > the enum above), unfortunately not during the next week [wait for my next
> > mail].
> 
> How about not modifying the double-click, which people are used to to
> add tracks at the bottom without starting to play, and use the middle
> click for the new feature?

So what is your preference what should happen on double-click? a), b) or c), 
or do you suggest some d)? How/if ever should we take KDE's settings (single 
vs. double click) into account?

	Matěj