Review Request 111212: Kill long running scripts

[Anmol Ahuja]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111212/
-----------------------------------------------------------

(Updated June 25, 2013, 7:19 p.m.)


Review request for Amarok.


Description
-------

Added the ability to kill a long running script.
Refactored a bit.


Diffs (updated)
-----

  src/ScriptManager.h afaa832 
  src/ScriptManager.cpp b7f0a5c 
  src/amarokconfig.kcfg 6b4cefe 
  src/configdialog/dialogs/ScriptsConfig.ui b4b8d37 
  src/scriptengine/AmarokScriptableServiceScript.cpp a312671 

Diff: http://git.reviewboard.kde.org/r/111212/diff/


Testing
-------


File Attachments (updated)
----------------

script
  http://git.reviewboard.kde.org/media/uploaded/files/2013/06/25/benchmark.zip


Thanks,

Anmol Ahuja

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130625/b0ed5df6/attachment.html>