Review Request 111212: Kill long running scripts

[Mark Kretschmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111212/#review35037
-----------------------------------------------------------



src/amarokconfig.kcfg
<http://git.reviewboard.kde.org/r/111212/#comment25642>

    Why does this need a configuration option? Can you think of any use case where a user would not want to be warned?



src/amarokconfig.kcfg
<http://git.reviewboard.kde.org/r/111212/#comment25643>

    Why would the user want to change the interval? I don't think anyone could tell what impact this has.


- Mark Kretschmann


On June 24, 2013, 10:40 a.m., Anmol Ahuja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111212/
> -----------------------------------------------------------
> 
> (Updated June 24, 2013, 10:40 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Added the ability to kill a long running script.
> Refactored a bit.
> 
> 
> Diffs
> -----
> 
>   src/ScriptManager.h afaa832 
>   src/ScriptManager.cpp b7f0a5c 
>   src/amarokconfig.kcfg 6b4cefe 
>   src/configdialog/dialogs/ScriptsConfig.ui b4b8d37 
>   src/scriptengine/AmarokScriptableServiceScript.cpp a312671 
> 
> Diff: http://git.reviewboard.kde.org/r/111212/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anmol Ahuja
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130625/891c504e/attachment.html>