[amarok] /: Cleaned up playlist multilevel sorting algorithm. Added album artist special case to playlist sorting.

Myriam Schweingruber myriam at kde.org
Thu Jun 20 10:22:22 UTC 2013


Shouldn't this be added to the ChangeLog?

On Sat, Apr 27, 2013 at 11:11 AM, Matěj Laitl <matej at laitl.cz> wrote:
> Git commit 583158f4c4d25098aa1f0bb6b683813488580d52 by Matěj Laitl, on behalf of Konrad Zemek.
> Committed on 27/04/2013 at 11:08.
> Pushed by laitl into branch 'master'.
>
> Cleaned up playlist multilevel sorting algorithm. Added album artist special case to playlist sorting.
>
> It fixes an issue with two albums being merged on the playlist when they happen to have the same name, and sorting by album is enabled.
> Originally thought to fix bug 271105, it actually fixes some other, but connected, one (see my comment https://bugs.kde.org/show_bug.cgi?id=271105#c10 ).
>
> Thanks go to Konrad Zemek for the patch.
>
> REVIEW: 110070
> CCBUG: 271105
>
> M  +114  -83   src/playlist/proxymodels/SortAlgorithms.cpp
> M  +3    -0    src/playlist/proxymodels/SortAlgorithms.h
> M  +19   -13   src/playlist/proxymodels/SortScheme.cpp
> M  +11   -8    src/playlist/proxymodels/SortScheme.h
> M  +2    -2    tests/mocks/MetaMock.h
> M  +63   -44   tests/playlist/TestPlaylistModels.cpp
>
> http://commits.kde.org/amarok/583158f4c4d25098aa1f0bb6b683813488580d52
>
...

-- 
Proud member of the Amarok and KDE Community
Protect your freedom and join the Fellowship of FSFE:
http://www.fsfe.org
Please don't send me proprietary file formats,
use ISO standard ODF instead (ISO/IEC 26300)


More information about the Amarok-devel mailing list