Review Request 110855: Add dbus methods for updating all existing podcast and adding new podcast

[Shubham Chaudhary]

> On June 8, 2013, 12:32 p.m., Vedant Agarwala wrote:
> > Seems like a good patch. Did you test it with any script? It will be better if you do and even better if you attach a screen shot of that depicts the working.
> 
> Matěj Laitl wrote:
>     Thanks for your review, Vedant. We welcome patch reviews from non-members of the core Amarok team and you've pointed out things I would point out too (method name, trailing whitespace, style..). However, please state that you are not (yet) a member of the core Amarok development team in such reviews to reduce any possible confusion. Best is probably to present the review as a couple of non-binding friendly suggestions from a fellow contributor, not necessarily endorsed by The Amarok Team.
> 
> Vedant Agarwala wrote:
>     Ok Matej will do that in the future. I felt the same after he fixed the issues and I couldn't do anything there after, like a core member would have.
>     
>     And Shubham, sorry if there was any confusion. As you may have understood, I'm just a fellow contributor.

Well actually I talked to Matej in fisheye before you reviewed the patch, so I thought he handed over this task to you. But anyway Vedant thanks for the review. 
Matej can you please commit this patch, if there are no more issues.


- Shubham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110855/#review33930
-----------------------------------------------------------


On June 9, 2013, 12:02 a.m., Shubham Chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110855/
> -----------------------------------------------------------
> 
> (Updated June 9, 2013, 12:02 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Bug 205509 - JJ: add dbus functions to update podcasts and download podcast tracks
> I added two new methods for dbus: UpdateAllPodcast and AddPodcast
> 
> 
> This addresses bugs 205509 and Bug.
>     https://bugs.kde.org/show_bug.cgi?id=205509
>     https://bugs.kde.org/show_bug.cgi?id=Bug
> 
> 
> Diffs
> -----
> 
>   src/dbus/mpris1/org.freedesktop.MediaPlayer.tracklist.xml ee512b7 
>   src/dbus/mpris1/TrackListHandler.cpp b1f01cf 
>   src/dbus/mpris1/TrackListHandler.h 551999a 
> 
> Diff: http://git.reviewboard.kde.org/r/110855/diff/
> 
> 
> Testing
> -------
> 
> Tested both of these methods using qdbus
> qdbus org.kde.amarok /TrackList AddPodcast "http://feeds.feedburner.com/freakonomicsradio"
> qdbus org.kde.amarok /TrackList UpdateAllPodcast
> 
> 
> Thanks,
> 
> Shubham Chaudhary
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130611/2fec4c4f/attachment.html>