Review Request 110855: Add dbus methods for updating all existing podcast and adding new podcast

[Vedant Agarwala]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110855/#review33930
-----------------------------------------------------------


Seems like a good patch. Did you test it with any script? It will be better if you do and even better if you attach a screen shot of that depicts the working.


src/dbus/mpris1/TrackListHandler.h
<http://git.reviewboard.kde.org/r/110855/#comment24989>

    Spelling error: shouldn't the method name contain a 's' in the end?



src/dbus/mpris1/TrackListHandler.cpp
<http://git.reviewboard.kde.org/r/110855/#comment24990>

    remove trailing white spaces



src/dbus/mpris1/TrackListHandler.cpp
<http://git.reviewboard.kde.org/r/110855/#comment24992>

    if you like you can remove the braces in the if statement (like in line 127 in your code)



src/dbus/mpris1/TrackListHandler.cpp
<http://git.reviewboard.kde.org/r/110855/#comment24993>

    these are not debug statements. Make them errors.



src/dbus/mpris1/org.freedesktop.MediaPlayer.tracklist.xml
<http://git.reviewboard.kde.org/r/110855/#comment24991>

    same, trailing whitespace error


- Vedant Agarwala


On June 6, 2013, 7:45 p.m., Shubham Chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110855/
> -----------------------------------------------------------
> 
> (Updated June 6, 2013, 7:45 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Bug 205509 - JJ: add dbus functions to update podcasts and download podcast tracks
> I added two new methods for dbus: UpdateAllPodcast and AddPodcast
> 
> 
> This addresses bugs 205509 and Bug.
>     https://bugs.kde.org/show_bug.cgi?id=205509
>     https://bugs.kde.org/show_bug.cgi?id=Bug
> 
> 
> Diffs
> -----
> 
>   src/dbus/mpris1/TrackListHandler.h 551999a 
>   src/dbus/mpris1/TrackListHandler.cpp b1f01cf 
>   src/dbus/mpris1/org.freedesktop.MediaPlayer.tracklist.xml ee512b7 
> 
> Diff: http://git.reviewboard.kde.org/r/110855/diff/
> 
> 
> Testing
> -------
> 
> Tested both of these methods using qdbus
> qdbus org.kde.amarok /TrackList AddPodcast "http://feeds.feedburner.com/freakonomicsradio"
> qdbus org.kde.amarok /TrackList UpdateAllPodcast
> 
> 
> Thanks,
> 
> Shubham Chaudhary
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130608/07a01d5c/attachment.html>