Review Request 111804: Fix a crash on startup

[Fabian Kosmale]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111804/
-----------------------------------------------------------

(Updated July 31, 2013, 9:47 a.m.)


Review request for Amarok.


Changes
-------

Check if sort level is corrupted as requested by Konrad Zemek. See the inline comment too see why columnForName can't be used. Alternatively, one could introduce a new error value in the enum.


Description
-------

Without this patch, Amarok would crash with 
ASSERT failure in QList<T>::at: "index out of range"
when amarokrc contained
[Playlist Sorting]
SortPath=Shuffle


Diffs (updated)
-----

  src/playlist/PlaylistSortWidget.cpp 384e4a0eaa28f82eb27665a1a0d497e018a61161 

Diff: http://git.reviewboard.kde.org/r/111804/diff/


Testing
-------

Compiled and started Amarok. It doesn't crash anymore.


Thanks,

Fabian Kosmale

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130731/c107ca86/attachment.html>