Review Request 111635: PlaybackConfig: add option whether playback should start on track add

Mark Kretschmann kretschmann at kde.org
Wed Jul 24 16:21:39 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111635/#review36451
-----------------------------------------------------------



src/configdialog/dialogs/PlaybackConfig.ui
<http://git.reviewboard.kde.org/r/111635/#comment26908>

    The tooltip is too long, I think. In Amarok it is shown as one extremely long line. As QToolTip supports Rich Text, it might be better to break it up into paragraphs.


- Mark Kretschmann


On July 24, 2013, 2:41 p.m., Matěj Laitl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111635/
> -----------------------------------------------------------
> 
> (Updated July 24, 2013, 2:41 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> PlaybackConfig: add option whether playback should start on track add
> 
> CHANGES:
>  * Added an option whether adding tracks to playlist should start playing.
> 
> Also changed the entry in the 2.8 Beta ChangeLog, which is a bit strange,
> but I believe the ChangeLog is most useful for differences between major
> releases and it would be really confusing if the entry wasn't changed.
> 
> BUG: 322428
> FIXED-IN: 2.8
> 
> 
> Diffs
> -----
> 
>   ChangeLog 87e4708a6330e7a612db59052a50eef053294b06 
>   src/amarokconfig.kcfg c9d202ad1212055f5877769c7add897547bb3f38 
>   src/configdialog/dialogs/PlaybackConfig.ui 2bbcba7e2b8f7fdafe98929741e9d08a069460d0 
>   src/playlist/PlaylistController.h 185b4226c171c6a1fcd5b681721e39deae2e832b 
>   src/playlist/PlaylistController.cpp 1d770fdff54ddc7f6bd6f5d813c377108d6f674d 
> 
> Diff: http://git.reviewboard.kde.org/r/111635/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matěj Laitl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130724/59919f30/attachment.html>


More information about the Amarok-devel mailing list