Review Request 111510: Consistently use FindFFMpeg.cmake from kdelibs
Alex Merry
kde at randomguy3.me.uk
Mon Jul 15 13:18:45 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111510/
-----------------------------------------------------------
(Updated July 15, 2013, 1:18 p.m.)
Review request for Amarok.
Changes
-------
Now with Changelog entry.
Description
-------
Consistently use FindFFMpeg.cmake from kdelibs
FindFFMpeg from kdelibs works differently to our internal one (and, in
fact, more consistently with standard Find* files). Since we depends on
kdelibs anyway, we now just use the kdelibs one and don't bother
shipping our own.
Diffs (updated)
-----
ChangeLog 5fe5d2e64c771d722f3f90bf6c98d5013e56553c
cmake/modules/FindFFmpeg.cmake 0aa2cdc33a88953fe8b94532cb45c43ad35e0da8
src/CMakeLists.txt 589fddb9ea2177102cabd3a193a9e6848ea9c12d
Diff: http://git.reviewboard.kde.org/r/111510/diff/
Testing
-------
Build works with FFMpeg and libOFA installed, and kdelibs 4.10.5. No other configurations tested. (Without the patch, the build fails with this configuration).
Thanks,
Alex Merry
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130715/5ef37d42/attachment.html>
More information about the Amarok-devel
mailing list