Review Request 111449: Week 3: Revamping Amarok's Scripting Interface

[Anmol Ahuja]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111449/
-----------------------------------------------------------

Review request for Amarok and Mark Kretschmann.


Description
-------

New Script Console


Diffs
-----

  src/App.h b4d0f12 
  src/App.cpp 804ff6e 
  src/CMakeLists.txt 69a8ff4 
  src/ScriptManager.h afaa832 
  src/ScriptManager.cpp ab09fcf 
  src/amarokconfig.kcfg 6b4cefe 
  src/configdialog/dialogs/ScriptsConfig.cpp c04f1b1 
  src/configdialog/dialogs/ScriptsConfig.ui b4b8d37 
  src/context/applets/lyrics/LyricsApplet.cpp 0af35d2 
  src/context/applets/songkick/SongkickApplet.cpp ed93e56 
  src/context/engines/lyrics/LyricsEngine.cpp a65be19 
  src/dialogs/DiagnosticDialog.cpp 047d715 
  src/dialogs/deviceconfiguredialog.cpp e54edad 
  src/scriptconsole/ScriptConsole.h PRE-CREATION 
  src/scriptconsole/ScriptConsole.cpp PRE-CREATION 
  src/scriptconsole/ScriptConsole.ui PRE-CREATION 
  src/scriptconsole/ScriptConsoleItem.h PRE-CREATION 
  src/scriptconsole/ScriptConsoleItem.cpp PRE-CREATION 
  src/scriptconsole/ScriptEditorDocument.h PRE-CREATION 
  src/scriptconsole/ScriptEditorDocument.cpp PRE-CREATION 
  src/scriptconsole/ScriptItemDelegate.h PRE-CREATION 
  src/scriptconsole/ScriptItemDelegate.cpp PRE-CREATION 
  src/scriptengine/AmarokCollectionScript.cpp 3fcda84 
  src/scriptengine/AmarokEngineScript.cpp 5471838 
  src/scriptengine/AmarokInfoScript.cpp 4d06568 
  src/scriptengine/AmarokKNotifyScript.cpp b98efed 
  src/scriptengine/AmarokLyricsScript.cpp b1972fa 
  src/scriptengine/AmarokNetworkScript.cpp 0eaa440 
  src/scriptengine/AmarokOSDScript.cpp 659cd68 
  src/scriptengine/AmarokPlaylistScript.cpp 2dde634 
  src/scriptengine/AmarokScript.cpp b21a2ec 
  src/scriptengine/AmarokScriptConfig.cpp 457104a 
  src/scriptengine/AmarokScriptableServiceScript.cpp a312671 
  src/scriptengine/AmarokServicePluginManagerScript.cpp 86f841c 
  src/scriptengine/AmarokStatusbarScript.cpp 6efbb38 
  src/scriptengine/AmarokWindowScript.cpp c9a65ee 
  src/scriptengine/ScriptImporter.cpp 8c2a933 
  src/scriptengine/exporters/CollectionTypeExporter.cpp PRE-CREATION 
  src/scriptengine/exporters/MetaTypeExporter.cpp PRE-CREATION 
  src/scriptengine/exporters/QueryMakerExporter.cpp PRE-CREATION 
  src/scriptmanager/ScriptItem.h PRE-CREATION 
  src/scriptmanager/ScriptItem.cpp PRE-CREATION 
  src/scriptmanager/ScriptManager.h PRE-CREATION 
  src/scriptmanager/ScriptManager.cpp PRE-CREATION 
  src/services/scriptable/ScriptableService.cpp ee8bdfa 
  src/services/scriptable/ScriptableServiceInfoParser.cpp 998135b 
  src/services/scriptable/ScriptableServiceManager.cpp aa28a6c 
  src/services/scriptable/ScriptableServiceQueryMaker.cpp 8a6d536 

Diff: http://git.reviewboard.kde.org/r/111449/diff/


Testing
-------


Thanks,

Anmol Ahuja

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130708/1dce3ff6/attachment.html>