Review Request 110082: fixes Bug 275821 - JJ: Proper tooltips for Saved Playlists; remove Playlist::description() method

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110082/#review35435
-----------------------------------------------------------


This review has been submitted with commit 6ef8e597851e8e5638c7714c9b2649213db2732e by Mark Kretschmann on behalf of Vedant Agarwala to branch master.

- Commit Hook


On June 3, 2013, 8:23 p.m., Vedant Agarwala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110082/
> -----------------------------------------------------------
> 
> (Updated June 3, 2013, 8:23 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> As agreed on the review for https://git.reviewboard.kde.org/r/104048/ , Qt::TooltipRole has been updated so that now the tooltip displays full name of the playlist. Occurrences of "description" have been removed (from the Playlist base class as well as the subclasses).
> 
> 
> This addresses bug 275821.
>     https://bugs.kde.org/show_bug.cgi?id=275821
> 
> 
> Diffs
> -----
> 
>   src/browsers/playlistbrowser/PlaylistBrowserModel.cpp d2b55ff 
>   src/core-impl/collections/mediadevicecollection/playlist/MediaDevicePlaylist.h 6b25e59 
>   src/core-impl/collections/mediadevicecollection/playlist/MediaDevicePlaylist.cpp 1ad4d55 
>   src/core-impl/playlists/types/file/PlaylistFile.h bd88199 
>   src/core-impl/playlists/types/file/PlaylistFile.cpp 073e140 
>   src/core/playlists/Playlist.h 39ecb30 
>   src/playlistmanager/SyncedPlaylist.h fd2f966 
>   src/playlistmanager/SyncedPlaylist.cpp 985f087 
>   src/playlistmanager/sql/SqlPlaylist.h d28d161 
>   src/playlistmanager/sql/SqlPlaylist.cpp 98f24d2 
>   src/playlistmanager/sql/SqlPlaylistGroup.cpp 2862034 
>   src/playlistmanager/sql/SqlUserPlaylistProvider.h 273a050 
>   src/playlistmanager/sql/SqlUserPlaylistProvider.cpp d9209d2 
> 
> Diff: http://git.reviewboard.kde.org/r/110082/diff/
> 
> 
> Testing
> -------
> 
> Testing done. Works. Builds successfully and passes the tests.
> 
> 
> File Attachments
> ----------------
> 
> displays the new tooltip
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/amarok_screenshot1.png
> displays the new tooltip
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/amarok_screenshot.png
> 
> 
> Thanks,
> 
> Vedant Agarwala
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130702/16dfdd0c/attachment-0001.html>