Review Request 111038: Fixes the scrolling problem in dynamic playlists i.e. Bug 284214

Commit Hook null at kde.org
Tue Jul 2 10:15:37 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111038/
-----------------------------------------------------------

(Updated July 2, 2013, 10:15 a.m.)


Status
------

This change has been marked as submitted.


Review request for Amarok.


Description
-------

After the track was changed the "scroll to current playing track" worked as per user settings. But in case of dynamic playlists after the tracks were added (automatically) the PrettyListView scrolled to the tracks added (i.e. it scrolled to the bottom). It took me so long to figure this out and even longer to find a solution; but the patch was only of 2 lines. Anyway I got a better understanding of the Playlist Model-View architecture :)


This addresses bug 284214.
    https://bugs.kde.org/show_bug.cgi?id=284214


Diffs
-----

  src/playlist/view/listview/PrettyListView.cpp 8723875 

Diff: http://git.reviewboard.kde.org/r/111038/diff/


Testing
-------

Builds successfully and runs as expected


Thanks,

Vedant Agarwala

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130702/04e08b62/attachment.html>


More information about the Amarok-devel mailing list