Review Request 111343: Week 2: Revamping Amarok's Scripting Interface

[Mark Kretschmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111343/#review35427
-----------------------------------------------------------



src/ScriptManager.h
<http://git.reviewboard.kde.org/r/111343/#comment25955>

    Please remove the Ptr suffix from pointer members and accessors. Just name it m_service, service() etc.



src/scriptengine/AmarokCollectionScript.h
<http://git.reviewboard.kde.org/r/111343/#comment25956>

    Looks like something is missing here?



src/scriptengine/AmarokCollectionScript.h
<http://git.reviewboard.kde.org/r/111343/#comment25958>

    This should probably be const



src/scriptengine/AmarokCollectionScript.h
<http://git.reviewboard.kde.org/r/111343/#comment25959>

    This should probably be const



src/scriptengine/AmarokCollectionScript.cpp
<http://git.reviewboard.kde.org/r/111343/#comment25957>

    Use the KDE_DEPRECATED macro



src/scriptengine/ScriptingDefines.h
<http://git.reviewboard.kde.org/r/111343/#comment25960>

    Better variable name please


- Mark Kretschmann


On July 1, 2013, 12:41 p.m., Anmol Ahuja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111343/
> -----------------------------------------------------------
> 
> (Updated July 1, 2013, 12:41 p.m.)
> 
> 
> Review request for Amarok and Mark Kretschmann.
> 
> 
> Description
> -------
> 
> Week 2: Added scripting interface for the collection management.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 69a8ff4 
>   src/ScriptManager.h afaa832 
>   src/ScriptManager.cpp b7f0a5c 
>   src/core/collections/Collection.h 7e2957d 
>   src/core/collections/QueryMaker.h 92b6a65 
>   src/scriptengine/AmarokCollectionScript.h 5733947 
>   src/scriptengine/AmarokCollectionScript.cpp 3fcda84 
>   src/scriptengine/AmarokEngineScript.h aa2b112 
>   src/scriptengine/AmarokEngineScript.cpp 5471838 
>   src/scriptengine/AmarokPlaylistScript.h 28f9d7e 
>   src/scriptengine/AmarokPlaylistScript.cpp 2dde634 
>   src/scriptengine/AmarokWindowScript.cpp c9a65ee 
>   src/scriptengine/MetaTypeExporter.h 031e52b 
>   src/scriptengine/MetaTypeExporter.cpp 5a515a6 
>   src/scriptengine/ScriptingDefines.h PRE-CREATION 
>   src/scriptengine/exporters/CollectionTypeExporter.h PRE-CREATION 
>   src/scriptengine/exporters/CollectionTypeExporter.cpp PRE-CREATION 
>   src/scriptengine/exporters/MetaTypeExporter.h PRE-CREATION 
>   src/scriptengine/exporters/MetaTypeExporter.cpp PRE-CREATION 
>   src/scriptengine/exporters/QueryMakerExporter.h PRE-CREATION 
>   src/scriptengine/exporters/QueryMakerExporter.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111343/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anmol Ahuja
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130702/d735b1be/attachment.html>