Amarok 2.7 power management

Matěj Laitl matej at laitl.cz
Wed Jan 23 15:32:02 UTC 2013


On 23. 1. 2013 James Daniel Smith wrote:
> Patch for enabling Amarok power inhibition based on Amarok playing state. 
> Based on 2.7.0 release.

Hi,
thanks for the patch, good idea. However, slotStateChanged() isn't IMO the 
best place, because it can be called rather frequently (tens of times per a 
song) and might cause Solid going to sleep while the EngineController 
transitions to the next song.

Better approach would be to create a mini-object (RAII!) SleepInhibitor under 
playback/ that would connect to EngineController's playing(), stopped() (and 
paused()?) signals which should be less bumpy.

Would you mind improving the patch as suggested and posting it to 
http://reviewbard.kde.org/ ?

	Matěj


More information about the Amarok-devel mailing list