Review Request 108542: Support for .opus file tags added

[Martin Brodbeck]

> On Jan. 22, 2013, 2:39 p.m., Matěj Laitl wrote:
> > shared/tag_helpers/TagHelper.cpp, line 276
> > <http://git.reviewboard.kde.org/r/108542/diff/1/?file=108588#file108588line276>
> >
> >     Amarok::Opus instead of Amarok::Ogg here?

I'm not sure about Amarok::Opus, because it's an Ogg container? Flac also uses Amarok::Ogg. But to be honest I don't know what exactly this parameter means...


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108542/#review25977
-----------------------------------------------------------


On Jan. 22, 2013, 4:30 p.m., Martin Brodbeck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108542/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2013, 4:30 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Support for .opus file tags added. Not sure about the mime type. Recent version of taglib necessary.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt f87e05e 
>   shared/FileType.h b3d4470 
>   shared/FileType.cpp 43d8777 
>   shared/FileTypeResolver.cpp 63a83e1 
>   shared/config.h.cmake 004dd57 
>   shared/tag_helpers/TagHelper.cpp 4534018 
> 
> Diff: http://git.reviewboard.kde.org/r/108542/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Brodbeck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130122/42f21fe6/attachment-0001.html>