Review Request 108413: FindMySQLAmarok.cmake: use PATH_SUFFIXES

[Alexander Neundorf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108413/#review25689
-----------------------------------------------------------


Is /opt/local for OSX ? Or is this used also on other platforms ?
This is then searched anyway, see cmake/Modules/Platforms/Darwin.cmake.

${BIN_INSTALL_DIR} is probably also not necessary, since ${CMAKE_INSTALL_PREFIX} is checked always (see UnixPaths.cmake).

- Alexander Neundorf


On Jan. 15, 2013, 4:26 a.m., Yury Georgievich Kudryashov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108413/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2013, 4:26 a.m.)
> 
> 
> Review request for Amarok and Build System.
> 
> 
> Description
> -------
> 
> FindMySQLAmarok.cmake: use PATH_SUFFIXES
> 
> Drop ~/usr and /opt from find_path(). Use CMAKE_PREFIX_PATH.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindMySQLAmarok.cmake 910b434bda138117a4a2598bd7f5aa5f3d58ee10 
> 
> Diff: http://git.reviewboard.kde.org/r/108413/diff/
> 
> 
> Testing
> -------
> 
> - install mysql into a non-standard path
> - try to build amarok
> 
> 
> Thanks,
> 
> Yury Georgievich Kudryashov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130116/d1c6f3ac/attachment.html>