Review Request: fix amarok random play by correctly seeding using qsrand
Commit Hook
null at kde.org
Fri Jan 11 01:24:46 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108310/#review25209
-----------------------------------------------------------
This review has been submitted with commit 105e026ef8722d48f05a51a441bd135270ba22ca by Matěj Laitl on behalf of Daniel Schmitz to branch master.
- Commit Hook
On Jan. 9, 2013, 9:56 p.m., Daniel Schmitz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108310/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2013, 9:56 p.m.)
>
>
> Review request for Amarok.
>
>
> Description
> -------
>
> Where qrand is invoked in RandomTrackNavigator.cpp, there is no prior call to qsrand. Thus it uses an unseeded random-number-generator. This makes amarok play the sames files everytime it starts. This patch adds a call to qsrand in RandomTrackNavigator's constructor.
>
>
> Diffs
> -----
>
> src/playlist/navigators/RandomTrackNavigator.cpp 5a2155a
>
> Diff: http://git.reviewboard.kde.org/r/108310/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Daniel Schmitz
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130111/c09c64a2/attachment.html>
More information about the Amarok-devel
mailing list