Review Request: fix amarok random play by correctly seeding using qsrand

Daniel Schmitz daniel.schmitz at gmx.info
Wed Jan 9 20:52:57 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108310/
-----------------------------------------------------------

Review request for Amarok.


Description
-------

Where qrand is in invoked RandomTrackNavigator.cpp, there is no prior call to qsrand. Thus it uses an unseeded random-number-generator. This makes amarok play the sames files everytime it starts. This patch adds a call to qsrand in RandomTrackNavigator's constructor.


Diffs
-----

  src/playlist/navigators/RandomTrackNavigator.cpp 5a2155a 

Diff: http://git.reviewboard.kde.org/r/108310/diff/


Testing
-------


Thanks,

Daniel Schmitz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130109/3798c0c8/attachment.html>


More information about the Amarok-devel mailing list