Review Request: Fix duplicate name bug in creating playlist folders

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108245/#review24947
-----------------------------------------------------------



src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp
<http://git.reviewboard.kde.org/r/108245/#comment19125>

    Not bad, but you can find max number even without creating a list of all numbers (and including <algorithm>), just remember the max number ever stumbled upon and raise it when you come across a greater number.


- Matěj Laitl


On Jan. 7, 2013, 4:44 p.m., Andromeda Galaxy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108245/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2013, 4:44 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> This patch fixes a problem where folder-names were lexiographically sorted to find the largest number of duplicates
> 
> 
> Diffs
> -----
> 
>   src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp f6f06d6 
> 
> Diff: http://git.reviewboard.kde.org/r/108245/diff/
> 
> 
> Testing
> -------
> 
> The unit tests pass, and this appears to fix the problem in the ui once compiled.
> 
> 
> Thanks,
> 
> Andromeda Galaxy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130107/acfa5d27/attachment.html>