Review Request: Amarok queued track number icon scalable

[Matěj Laitl]

> On Jan. 7, 2013, 12:31 p.m., Myriam Schweingruber wrote:
> > Sorry to be so nitpicking, but could we have at least the same color for the new icon? The color of the old icon fits in the current icon scheme, so this should be respected.
> 
> Riccardo Ferrazzo wrote:
>     The first version of this patch uses the same colour of the previous icon but i was asked to use the user's color scheme with kcolorscheme, so i've changed the code to reflect this requirement. as you can see in the 4th comment

I back the change to use KColorscheme. We use system colours for the playlist view, so the old hard-coded colour in SVG file was actually wrong and could have bad contrast on non-default colour schemes.


- Matěj


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107796/#review24897
-----------------------------------------------------------


On Jan. 7, 2013, 10:37 a.m., Riccardo Ferrazzo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107796/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2013, 10:37 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> I've replaced the svg queue icon with a painted green rounded rectangle that scale based on the digits to display
> 
> 
> This addresses bug 253802.
>     https://bugs.kde.org/show_bug.cgi?id=253802
> 
> 
> Diffs
> -----
> 
>   src/images/default-theme-clean.svg 6bad334 
>   src/images/default-theme.svg dbd3c90 
>   src/playlist/view/listview/PrettyItemDelegate.cpp c13542b 
> 
> Diff: http://git.reviewboard.kde.org/r/107796/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> before
>   http://git.reviewboard.kde.org/r/107796/s/918/
> after
>   http://git.reviewboard.kde.org/r/107796/s/919/
> 
> 
> Thanks,
> 
> Riccardo Ferrazzo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130107/0e86e59c/attachment.html>