Review Request: Fix one small memoy leak when switch track in amarok

[Matěj Laitl]

> On Jan. 1, 2013, 7:48 p.m., Bart Cerneels wrote:
> > I don't know what that code is supposed to do, but if it's executed on each track change it likely is a real leak. Test if it doesn't cause dangling pointer crashes and ship it.

It doesn't cause dangling pointers and fixes a real leak, I will commit later today a RAII (QScopedPointer) version of this patch.


- Matěj


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108050/#review24379
-----------------------------------------------------------


On Dec. 31, 2012, 2:06 p.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108050/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2012, 2:06 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> I notice this when invesigating bug 298627. Amarok still leaks memory for me , but at least it seems to leaks less now.
> 
> 
> Diffs
> -----
> 
>   src/playlist/PlaylistBreadcrumbItemSortButton.cpp 95dba20 
> 
> Diff: http://git.reviewboard.kde.org/r/108050/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130101/81f5bd17/attachment.html>