Review Request 109156: Be consistent with width range of playlist layout setting.

[Yichao Yu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109156/
-----------------------------------------------------------

(Updated Feb. 25, 2013, 11:12 p.m.)


Review request for Amarok.


Description
-------

1. Always make minimum width in automatic mode 0% (and show as 0%), and 1% in custom mode (and prevent accidentally set to automatic mode in custom mode). The minimum width of custom mode was only 1% if it was just switched from automatic mode.
2. Remove the limit on custom width setting. This make it hard to increase width setting and not consistent with the condition after switching (custom/automatic) mode. See the related bug.


This addresses bug 315755.
    https://bugs.kde.org/show_bug.cgi?id=315755


Diffs (updated)
-----

  src/playlist/layouts/LayoutEditDialog.cpp 44f778f 

Diff: http://git.reviewboard.kde.org/r/109156/diff/


Testing
-------

Compiled and run. The width range is consistent and it is possible to increase width now.


Thanks,

Yichao Yu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130225/a817de98/attachment.html>