Review Request 108907: Added transcoding for opus format

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108907/#review28082
-----------------------------------------------------------

Ship it!


Looks good to me, thanks!

If you want to help even more, please solve one nitpick and add ChangeLog line (under 2.8 FEATURES, on top)


src/core/transcoding/formats/TranscodingOpusFormat.h
<http://git.reviewboard.kde.org/r/108907/#comment21008>

    nicpick: whitespace at the end of line


- Matěj Laitl


On Feb. 19, 2013, 9:11 a.m., Martin Brodbeck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108907/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2013, 9:11 a.m.)
> 
> 
> Review request for Amarok and Matěj Laitl.
> 
> 
> Description
> -------
> 
> In addition to request #108542, this patch adds opus transcoding.
> 
> 
> Diffs
> -----
> 
>   src/core/transcoding/formats/TranscodingOpusFormat.cpp PRE-CREATION 
>   src/core/CMakeLists.txt 2809dc3 
>   src/core/transcoding/TranscodingConfiguration.cpp f1de929 
>   src/core/transcoding/TranscodingController.cpp 265d1f8 
>   src/core/transcoding/TranscodingDefines.h 8c68f15 
>   src/core/transcoding/formats/TranscodingOpusFormat.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/108907/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Brodbeck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130225/a46a0de6/attachment.html>