Review Request 109156: Be consistent with width range of playlist layout setting.

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109156/#review28079
-----------------------------------------------------------


Hi, thanks for the patch. While we think about the actual changes in logic, please fix the code style issues.


src/playlist/layouts/LayoutEditDialog.cpp
<http://git.reviewboard.kde.org/r/109156/#comment21005>

    This change goes actually agains Amarok coding style, please see the HACKING folder.



src/playlist/layouts/LayoutEditDialog.cpp
<http://git.reviewboard.kde.org/r/109156/#comment21007>

    code style issues introduced


- Matěj Laitl


On Feb. 25, 2013, 8:01 p.m., Yichao Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109156/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2013, 8:01 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> 1. Always make minimum width in automatic mode 0% (and show as 0%), and 1% in custom mode (and prevent accidentally set to automatic mode in custom mode). The minimum width of custom mode was only 1% if it was just switched from automatic mode.
> 2. Remove the limit on custom width setting. This make it hard to increase width setting and not consistent with the condition after switching (custom/automatic) mode. See the related bug.
> 
> 
> This addresses bug 315755.
>     https://bugs.kde.org/show_bug.cgi?id=315755
> 
> 
> Diffs
> -----
> 
>   src/playlist/layouts/LayoutEditDialog.cpp 44f778f 
> 
> Diff: http://git.reviewboard.kde.org/r/109156/diff/
> 
> 
> Testing
> -------
> 
> Compiled and run. The width range is consistent and it is possible to increase width now.
> 
> 
> Thanks,
> 
> Yichao Yu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130225/300e3f29/attachment.html>