Review Request 109079: Patch for bug 240409 by adding bookmarks
Abhinandan Ramaprasath
abhiin1947 at gmail.com
Thu Feb 21 14:00:48 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109079/
-----------------------------------------------------------
Review request for Amarok.
Description
-------
This patch adds chapter support to m4b,m4a file formats. For now, libmp4v2 is a required dependency but will make it optional in the next update.
I thought we could give the user an option to choose if he wants the bookmarks or the multitrack display of chapters, but that's up for discussion.
This addresses bug https://bugs.kde.org/show_bug.cgi?id=240409.
https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=240409
Diffs
-----
CMakeLists.txt d96cbc9
cmake/modules/FindLibMP4.cmake PRE-CREATION
src/playlist/PlaylistController.cpp e5bde8b
Diff: http://git.reviewboard.kde.org/r/109079/diff/
Testing
-------
Thanks,
Abhinandan Ramaprasath
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130221/16dc7aeb/attachment.html>
More information about the Amarok-devel
mailing list