Review Request 108542: Support for .opus file tags added

[Martin Brodbeck]

> On Feb. 9, 2013, 2:17 a.m., Matěj Laitl wrote:
> > shared/FileTypeResolver.cpp, lines 20-21
> > <http://git.reviewboard.kde.org/r/108542/diff/2/?file=108702#file108702line20>
> >
> >     Why is including config.h needed for TAGLIB_OPUS_FOUND while it isn't needed for TAGLIB_MOD_FOUND?

That's a good question. Are you sure that the TAGLIB_MOD_FOUND part compiles? Here, for the OPUS stuff, I need the include.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108542/#review27046
-----------------------------------------------------------


On Jan. 22, 2013, 4:30 p.m., Martin Brodbeck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108542/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2013, 4:30 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Support for .opus file tags added. Not sure about the mime type. Recent version of taglib necessary.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt f87e05e 
>   shared/FileType.h b3d4470 
>   shared/FileType.cpp 43d8777 
>   shared/FileTypeResolver.cpp 63a83e1 
>   shared/config.h.cmake 004dd57 
>   shared/tag_helpers/TagHelper.cpp 4534018 
> 
> Diff: http://git.reviewboard.kde.org/r/108542/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Brodbeck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130211/3fe1ca06/attachment.html>