Review Request 108716: FIX Randomize playlist with Ctrl+H

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108716/#review27059
-----------------------------------------------------------


The patch looks good now, just some last trivial things. (sorry about being this picky)

(optional) If you want to help even more, please add:
 * BUG: XXXXXX commit tag (see http://techbase.kde.org/Development/Git/Configuration#Commit_Template)
 * REVIEW: YYYYYY commit tag (see above)
 * ChangeLog entry (on top, under FEATURES, ensure there is (BR XXXXXX) tag)


src/MainWindow.cpp
<http://git.reviewboard.kde.org/r/108716/#comment20380>

    Nitpick: Amarok coding style says:
    
    m_playlistDock.data()->sortWidget()->addLevel( QString( "Shuffle" ) );



src/MainWindow.cpp
<http://git.reviewboard.kde.org/r/108716/#comment20381>

    Amarok coding style says:
    
    connect( action, SIGNAL(triggered(bool)), this, SLOT(slotShufflePlaylist()) );
    
    (note that SIGNAL/SLOT macros are the only exception when there are no spaces around arguments)


- Matěj Laitl


On Feb. 9, 2013, 7:03 a.m., Harsh Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108716/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2013, 7:03 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Added a shortcut button for shuffle with default shortcut as Ctrl + H.
> Created a slot shuffleTrack() in mainWindow.cpp which is triggered on pressing Ctrl + H
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.h 4b23679 
>   src/MainWindow.cpp 8587784 
> 
> Diff: http://git.reviewboard.kde.org/r/108716/diff/
> 
> 
> Testing
> -------
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Harsh Gupta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130209/66f57b02/attachment.html>