Review Request 108716: FIX Randomize playlist with Ctrl+H

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108716/#review27047
-----------------------------------------------------------


Hi, thanks for the patch, looks good - just one badly chosen name.


src/MainWindow.h
<http://git.reviewboard.kde.org/r/108716/#comment20375>

    This should be caller more desctiptively, perhaps slotShufflePlaylist()


P.S.: there's no need to attach the copy of the patch as a file.

- Matěj Laitl


On Feb. 3, 2013, 4:34 p.m., Harsh Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108716/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2013, 4:34 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Added a shortcut button for shuffle with default shortcut as Ctrl + H.
> Created a slot shuffleTrack() in mainWindow.cpp which is triggered on pressing Ctrl + H
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.h 4b23679 
>   src/MainWindow.cpp 8587784 
> 
> Diff: http://git.reviewboard.kde.org/r/108716/diff/
> 
> 
> Testing
> -------
> 
> All tests passed.
> 
> 
> File Attachments
> ----------------
> 
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/02/02/0001-Randomize-playlist-with-Ctrl-H.patch
> 
> 
> Thanks,
> 
> Harsh Gupta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130209/e4e08ce1/attachment.html>