Review Request 114563: Make sure not to use video stream when transcoding to Opus

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114563/#review45950
-----------------------------------------------------------

Ship it!


This patch looks good to me, but I wonder - other formats may need a similar option, don't they?

- Matěj Laitl


On Dec. 20, 2013, 11:06 a.m., Martin Brodbeck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114563/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2013, 11:06 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> I stumbled over a problem with transcoding to Opus. For example, if a MP3 file contains cover art and you transcode it to Opus, ffmpeg creates an Opus file with two streams: Ogg Theora (because of the picture) and Opus. Thus, this patch makes sure not to use video streams.
> 
> 
> Diffs
> -----
> 
>   src/core/transcoding/formats/TranscodingOpusFormat.cpp dc6b743 
> 
> Diff: http://git.reviewboard.kde.org/r/114563/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Brodbeck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20131220/7af27729/attachment.html>