Review Request 112169: Stop after current track to tray menu

[Mark Kretschmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112169/#review38514
-----------------------------------------------------------


I can't say that I am 100% happy with this addition. It does add some noise to a menu which is currently very clearly structured, simple, and easy to understand. In fact for Amarok 2.8 we managed to remove one item from it which didn't seem important to us ("Configure").

On the other hand I can see how this function could be useful to some. I am wondering though why the keyboard shortcut doesn't suffice.


- Mark Kretschmann


On Aug. 20, 2013, 2:50 a.m., Shitikanth Kashyap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112169/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2013, 2:50 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Add 'Stop after current track' action to tray menu.
> 
> 
> Diffs
> -----
> 
>   src/TrayIcon.cpp 5262595 
> 
> Diff: http://git.reviewboard.kde.org/r/112169/diff/
> 
> 
> Testing
> -------
> 
> Tested with current HEAD.
> 
> 
> Thanks,
> 
> Shitikanth Kashyap
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130825/eb32f36b/attachment.html>